Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only use valid inline loras, add subfolder support #2968

Merged
merged 1 commit into from
May 20, 2024
Merged

feat: only use valid inline loras, add subfolder support #2968

merged 1 commit into from
May 20, 2024

Conversation

mashb1t
Copy link
Collaborator

@mashb1t mashb1t commented May 20, 2024

No description provided.

@mashb1t mashb1t merged commit 7537612 into lllyasviel:develop May 20, 2024
@mashb1t mashb1t added this to the 2.4.0 milestone May 24, 2024
@ErroneousBosch
Copy link

if I have a lora in loras/foo/bar.safetensors, would that be <lora:bar:1> or <lora:foo/bar:1>?

@mashb1t
Copy link
Collaborator Author

mashb1t commented May 29, 2024

@ErroneousBosch this would be <lora:bar:1>
as the file path stem is used, see https://github.com/lllyasviel/Fooocus/blob/main/modules/util.py#L413

csokun pushed a commit to csokun/Fooocus that referenced this pull request Jun 16, 2024
@mashb1t @csokun
feat: only use valid inline loras, add subfolder support (lllyasviel#…
fa83045 
…2968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mashb1t @ErroneousBosch