Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full prompt log #1920

Merged
merged 4 commits into from
May 9, 2024
Merged

Full prompt log #1920

merged 4 commits into from
May 9, 2024

Conversation

docppp
Copy link
Contributor

@docppp docppp commented Jan 13, 2024

This PR adds hidden full raw prompts into the log file, so you can see applied styles in action.

@docppp docppp requested a review from lllyasviel as a code owner January 13, 2024 22:19
@docppp docppp mentioned this pull request Jan 13, 2024
eddyizm added a commit to eddyizm/Fooocus that referenced this pull request Jan 24, 2024
@mashb1t mashb1t linked an issue Jan 24, 2024 that may be closed by this pull request
@mashb1t
Copy link
Collaborator

mashb1t commented Jan 28, 2024

Is also most likely going to be in metadata handling in #1940

@mashb1t mashb1t added the Size S small change, basically no testing needed label Feb 9, 2024
@mashb1t mashb1t changed the base branch from main to develop May 9, 2024 17:35
@mashb1t
Copy link
Collaborator

mashb1t commented May 9, 2024

Hey @docppp, sorry that merging this PR took so long but nevertheless thank you for your contribution, much appreciated!
This feature has now been updated to the latest version of develop and now correctly adds the full positive and negative prompt to the log, but not to the image metadata.
Thanks again!

@mashb1t mashb1t merged commit bdd6b1a into lllyasviel:develop May 9, 2024
@mashb1t mashb1t added this to the 2.4.0 milestone May 9, 2024
csokun pushed a commit to csokun/Fooocus that referenced this pull request Jun 16, 2024
* Update async_worker.py

* Update private_logger.py

* refactor: only show full prompt details in logs, exclude from image metadata

---------

Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>
Co-authored-by: Manuel Schmid <dev@mash1t.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size S small change, basically no testing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add feature for style expansion
2 participants