Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design / Perf #1

Closed
builder-main opened this issue Jul 6, 2024 · 1 comment
Closed

Design / Perf #1

builder-main opened this issue Jul 6, 2024 · 1 comment

Comments

@builder-main
Copy link

builder-main commented Jul 6, 2024

Nice base thanks for sharing,
It seems overkill for each light to update itself, the Camera script should register all lights and update them. it would furthermore allow for general controls like a max number of light having shadow at a time and camera frustrum coverage priority.

@llamacademy
Copy link
Owner

You are right! Having the lights self-register with a camera (or cameras) would be a much more efficient way of handling things so it's only 1 Update call per camera instead of 1 update per light, and would also allow more interesting additional quality / optimizations that could be added on a camera-by-camera basis.

I chose this way to make it very clear to follow in the tutorial even for more beginner level developers. I will update the readme with some notes about further optimizations that could be done to make this more efficient and configurable.

@llamacademy llamacademy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
llamacademy added a commit that referenced this issue Jul 8, 2024
Add further optimization notes as described in Issue #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants