Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyyaml to requirements.in #421

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

blazewicz
Copy link
Contributor

Description

This gives information to package managers like pip that PyYAML is a required dependency.

Related Issue

#420

Motivation and Context

Fixes #420

How Has This Been Tested?

I believe no testing is required here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ljvmiranda921
Copy link
Owner

ljvmiranda921 commented Sep 21, 2020

Hey thanks for catching this! I'll try to merge within the week and make a new release that includes the same version!
In case you really need it right now, I suggest doing a git clone first, updating the file manually, and running python setup.py install
Will do my best to merge within the week! 👍

@ljvmiranda921 ljvmiranda921 self-requested a review October 3, 2020 10:35
@ljvmiranda921 ljvmiranda921 merged commit 0aca245 into ljvmiranda921:master Oct 3, 2020
@ljvmiranda921
Copy link
Owner

@all-contributors please add @blazewicz for bugfixes

@allcontributors
Copy link
Contributor

@ljvmiranda921

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@ljvmiranda921
Copy link
Owner

@all-contributors please add @blazewicz for bug

@allcontributors
Copy link
Contributor

@ljvmiranda921

I've put up a pull request to add @blazewicz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyYAML is not included with pip installation
2 participants