Skip to content

Commit

Permalink
chore: update PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
benjycui authored and lixiaoyang1992 committed Apr 26, 2018
1 parent a6cb958 commit 8ed6227
Showing 1 changed file with 16 additions and 3 deletions.
19 changes: 16 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@
First of all, thanks for your contribution! :-)
First of all, thank you for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!
Please makes sure that these checkboxes are checked before submitting your PR, thank you!

* [ ] Make sure you follow antd's [code convention](https://github.com/ant-design/ant-design/wiki/Code-convention-for-antd).
* [ ] Make sure that you follow antd's [code convention](https://github.com/ant-design/ant-design/wiki/Code-convention-for-antd).
* [ ] Run `npm run lint` and fix those errors before submitting in order to keep consistent code style.
* [ ] Rebase before creating a PR to keep commit history clear.
* [ ] Add some descriptions and refer relative issues for you PR.

Extra checklist:

**if** *isBugFix* **:**

* [ ] Make sure that you add at least one unit test for the bug which you had fixed.

**elif** *isNewFeature* **:**

* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update TypeScript definition for the component.
* [ ] Add unit tests for the feature.

0 comments on commit 8ed6227

Please sign in to comment.