-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds i term2 and alfred themes #11
base: master
Are you sure you want to change the base?
Adds i term2 and alfred themes #11
Conversation
Hey Ethan! I really dig what you did here. Let me have a closer look and I'll come back with some feedback. Cheers! :) |
I really love how Alfred theme turned out. The only thing I'm hesitant about would be the grey text. Eg.: for Noctis, Noctis Sereno and Noctis Obscuro the color would be Horizon For Fish Shell/Iterm2 I attached a screenshot which is the reflection of the way I would have used the colors. I don't know if the suggested changes can be implemented and/or If you will like them. I just thought you will not mind if I share some of my ideas. Please let me know how do you feel about it. 🙂 |
Thanks for the great feedback! I like all the suggestions, and will update them real quick this evening then post some new screenshots. |
Hey! Didn't have time to work on it last night but was able to take another look this evening. Unfortunately, some of the iTerm2 suggestions aren't going to be doable due to the limitations of the terminal color support. I'll reply back with some more information tomorrow |
No worries mate! |
@ethanfann Just wanted to say this looks great! |
@chibicode I still have plans to get these updated with some of @liviuschera's suggestions! I've just been pretty bad at getting back around to it |
I came here looking for an iterm2! Thank you very much! |
It's awesome, exactly what I was looking for. It's a shame it was abandoned 😔 |
By ethanfann (cf pr liviuschera#11 on origin: liviuschera#11 )
Oh wow this is a blast from the past! I'm still using Noctis but have since swapped back my terminal to a more stock theme. Looks like this would need some minor color updates as well as support for some of the newer variants. No promises but I'll try to take another look. (I know I said the same like 5 years ago) |
Might help land this if the Alfred and iTerm2 themes were split into separate PRs. I could possibly try to finish the iTerm2 themes up if a separate PR would be accepted. |
Greetings!
Really loving the theme, so I spent some time making Alfred and iTerm2 versions and I'm quite happy with the results. Thought I'd give you a chance to decide if they're up to par.
iTerm2 (w/ Fish shell)
Noctis
Noctis Azureus
Noctis Lux
Noctis Minimus
Noctis Obscuro
Noctis Sereno
Noctis Uva
Noctis Viola
Alfred
Noctis
Noctis Azureus
Noctis Lux
Noctis Minimus
Noctis Obscuro
Noctis Sereno
Noctis Uva
Noctis Viola