Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds i term2 and alfred themes #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adds i term2 and alfred themes #11

wants to merge 5 commits into from

Conversation

ethanfann
Copy link

@ethanfann ethanfann commented Feb 18, 2019

Greetings!

Really loving the theme, so I spent some time making Alfred and iTerm2 versions and I'm quite happy with the results. Thought I'd give you a chance to decide if they're up to par.

iTerm2 (w/ Fish shell)

Noctis

iterm2 - noctis

Noctis Azureus

iterm2 - noctis azureus

Noctis Lux

iterm2 - noctis lux

Noctis Minimus

iterm2 - noctis minimus

Noctis Obscuro

iterm2 - noctis obscuro

Noctis Sereno

iterm2 - noctis sereno

Noctis Uva

iterm2 - noctis uva

Noctis Viola

iterm2 - noctis viola

Alfred

Noctis

alfred - noctis

Noctis Azureus

alfred - noctis azureus

Noctis Lux

alfred - noctis lux

Noctis Minimus

alfred - noctis minimus

Noctis Obscuro

alfred - noctis obscuro

Noctis Sereno

alfred - noctis sereno

Noctis Uva

alfred - noctis uva

Noctis Viola

alfred - noctis viola

@liviuschera
Copy link
Owner

Hey Ethan!

I really dig what you did here. Let me have a closer look and I'll come back with some feedback.

Cheers! :)

@liviuschera
Copy link
Owner

I really love how Alfred theme turned out. The only thing I'm hesitant about would be the grey text.
What would you think about replacing the grey text with the color used for comments in each theme? It's just something I was wondering how it would feel/look like.

Eg.: for Noctis, Noctis Sereno and Noctis Obscuro the color would be Horizon #5b858b, similar to the attached screenshot (I changed only one line and although the text is bold the font weight should be normal).

noctis alfred

For Fish Shell/Iterm2 I attached a screenshot which is the reflection of the way I would have used the colors. I don't know if the suggested changes can be implemented and/or If you will like them. I just thought you will not mind if I share some of my ideas.

noctis iterm feedback

Please let me know how do you feel about it. 🙂

@ethanfann
Copy link
Author

Thanks for the great feedback!

I like all the suggestions, and will update them real quick this evening then post some new screenshots.

@ethanfann
Copy link
Author

Hey! Didn't have time to work on it last night but was able to take another look this evening. Unfortunately, some of the iTerm2 suggestions aren't going to be doable due to the limitations of the terminal color support. I'll reply back with some more information tomorrow

@liviuschera
Copy link
Owner

No worries mate!

@chibicode
Copy link

@ethanfann Just wanted to say this looks great!

@ethanfann
Copy link
Author

@chibicode I still have plans to get these updated with some of @liviuschera's suggestions! I've just been pretty bad at getting back around to it

@liviuschera liviuschera mentioned this pull request Feb 24, 2020
@hdpoliveira
Copy link

I came here looking for an iterm2! Thank you very much!

@TixieSalander
Copy link

It's awesome, exactly what I was looking for. It's a shame it was abandoned 😔

TixieSalander added a commit to TixieSalander/noctis-theme that referenced this pull request Jul 26, 2024
@ethanfann
Copy link
Author

Oh wow this is a blast from the past! I'm still using Noctis but have since swapped back my terminal to a more stock theme. Looks like this would need some minor color updates as well as support for some of the newer variants.

No promises but I'll try to take another look. (I know I said the same like 5 years ago)

@kaicataldo
Copy link

Might help land this if the Alfred and iTerm2 themes were split into separate PRs. I could possibly try to finish the iTerm2 themes up if a separate PR would be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants