Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HipChat API から room history を取得して JSON ファイルに保存する #8

Merged
merged 54 commits into from
Feb 13, 2018
Merged

HipChat API から room history を取得して JSON ファイルに保存する #8

merged 54 commits into from
Feb 13, 2018

Conversation

inouetakuya
Copy link
Contributor

@inouetakuya inouetakuya commented Feb 11, 2018 •
edited
Loading

HipChat API から room history を取得して JSON ファイルに保存できるようにする。

HipChat - API - View room history
https://www.hipchat.com/docs/apiv2/method/view_room_history

完了条件

  • HipChat API から room history JSON を取得できる（単発リクエスト）
  • room history JSON をファイルに保存できる
  • コマンドラインから起動できる
  • 指定した room のすべてのメッセージ履歴を取得できる
  • 指定した room のメッセージ履歴を時間範囲を指定して取得できる
  • 複数の room のメッセージ履歴を時間範囲を指定して取得できる
  • 進捗状況が標準出力される
  • 進捗状況がログに出力される（バックグラウンド処理のため）
  • 例外処理
  • Rate limits を考慮する

このプルリクエストではやらないこと

@inouetakuya inouetakuya self-assigned this Feb 11, 2018
@inouetakuya
Hipchat -> HipChat
3558b4f
@inouetakuya
Enable to command "bundle exec thor history:export"
0a9bbb7
@inouetakuya
Set "from" and "to" with fetch_room_history method
a263773
@inouetakuya
The settings suggested to provide a good initial experience with RSpec
e62aa6b
@inouetakuya
Set "from" and "to" with create_room_history_file method
34e43e3
@inouetakuya
Define result_hash_from method
fdc2c6f
@inouetakuya
Convert time to timestamp
38b108a
@inouetakuya
+ def create_room_history_file_list(room_id_or_name, from: nil, to: nil)
fb6f227
@inouetakuya
Fix specs
767040f
@inouetakuya
Enable to execute the command like "bundle exec thor history:export -…
d9696f5 
…-from=20171101 --to=20171107"
@inouetakuya
Comment about a bug in detail
0cd2c12
@inouetakuya
Format time to ISO8601
70d1a06
@inouetakuya
+ HipChatExporter::Room
8c179eb
@inouetakuya
Parse rooms.csv
a7a68e8
@inouetakuya
'UTC' is alias to 'Etc/UTC'
150df35
@inouetakuya
Use HipChatExporter::ROOT_PATH globally
bb7aed2
@inouetakuya
Rich thor interface
62075e1
@inouetakuya
Parse CSV file and export history of rooms
edbbfb5
@inouetakuya
TIME_ZONE is better than TIMEZONE
122e9ff
@inouetakuya
Rename module because HipChat is duplicated
2a11b9b
@inouetakuya
Remove an unnecessary spec
6433688
@inouetakuya
Move files
daa55f6
@inouetakuya
Namespace Task:: because using another History class
3c0479d
@inouetakuya
Exporter -> History
03ee88f
@inouetakuya
Improve method name
a8369fa
@inouetakuya
Simplify method name
be93e3d
@inouetakuya
Improve methods
3a6af1f
@inouetakuya
+ puts "Fetching history of #{room.name} (#{room.id}), date: \"#{to}\…
fb56918 
…", end-date: \"#{from}\", max-results: #{History::MAX_RESULTS}"
@inouetakuya
+ puts "Exporting history of #{room.name} (#{room.id})...".colorize(:…
aa2beed 
…cyan)
@inouetakuya
Set default value of "to" option
e13c854
@inouetakuya
Use say method instead of colorize
82af946
@inouetakuya
new file: spec/rooms.csv
cd0e232
@inouetakuya
Describe usage in detail
8c5b255
@inouetakuya
Fill room_id and room_name in rooms.csv (room_name is optional)
9a9f547
@inouetakuya
+ HipChatExporter.logger.info(message)
2879892
@inouetakuya
Log for task:history:export
e843774
@inouetakuya
Improve method name
22d3a78
@inouetakuya
Handle exception on exporting history
a73536a
@inouetakuya
Improve method name
9918269
@inouetakuya
Sleep 60 because of x-ratelimit-reset
1e7b1e7
@inouetakuya
+ sleep 64 # 60 + buffer
ce86c47
@inouetakuya
Look up exception.response.headers['x-ratelimit-reset']
2b220f4
@inouetakuya
Fetch with rate limit
839513a
@inouetakuya inouetakuya merged commit 3853860 into master Feb 13, 2018
@inouetakuya inouetakuya deleted the fetch-room-history branch February 13, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@inouetakuya inouetakuya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@inouetakuya