Support AVIF format encoding #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supercaracal
commented
Jan 31, 2025
| @@ -133,29 +133,44 @@ func MainHandler(w http.ResponseWriter, r *http.Request, conf *configure.Conf, l | |||
| case "jpeg": | |||
| if q.UseWebP() { | |||
| err = imageprocessor.EncodeWebP(w, img.GetImg(), q.Quality(), false) | |||
| } else if q.UseAVIF() { | |||
| w.Header().Set("Content-Type", "image/avif") | |||
There was a problem hiding this comment.
Browser downloads the response body as a file if the explicit header specification is none.
etsxxx
approved these changes
Feb 3, 2025
|
|
||
| opts := avif.Options{ | ||
| Threads: 0, // all available cores | ||
| Speed: avif.MaxSpeed, // bigger is faster, but lower compress ratio |
There was a problem hiding this comment.
praise: Considering the compression speed of AVIF, I agree with you that the default is speed first.
ieee0824
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libaomrequiredhttp://localhost:3000/Lenna.jpg?w=1618&h=1000116KB123mshttp://localhost:3000/Lenna.jpg?w=1618&h=1000&avif=true&quality=100606KB660mshttp://localhost:3000/Lenna.jpg?w=1618&h=1000&avif=true&quality=5085.4KB551mshttp://localhost:3000/Lenna.jpg?w=1618&h=1000&avif=true&quality=2011.8KB421msAlthough my monitor is cheap, it looks to me the image quality might be fine even if the quality is
20. The compression ratio is awesome but the encoding speed is slower. The lossless is useless for us. Since WebP is well-balanced, I think we should prior WebP than AVIF when both are specified in a query string. I implemented only an encoding feature for AVIF bacause I think it is a rare case that the format is being a source image.