-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add goreleaser settings #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supercaracal
force-pushed
the
add-go-releaser
branch
from
December 14, 2023 07:53
25ba283
to
8d46178
Compare
supercaracal
commented
Dec 14, 2023
etsxxx
approved these changes
Dec 15, 2023
supercaracal
commented
Dec 16, 2023
supercaracal
commented
Dec 16, 2023
ieee0824
approved these changes
Dec 18, 2023
This was referenced Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd say that it would be better to use tools instead of manual upload for distribution of built files.
Since fanlin depends on WebP library for Golang, it seems that we can't disable cgo. Also, in GitHub Actions, it looks difficult to do cross-compiling to Windows, macOS and ARM architectures on the latest Ubuntu machine if cgo enabled.
Please let me know if there are overlooking somethings. I'm not familiar with WebP. But I think it's OK if the following test case is passed in CI.
fanlin/lib/image/image_test.go
Lines 130 to 168 in 6a75afc