-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tensorflow for content detection in a production build #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2695 +/- ##
===================================================
+ Coverage 56.34804% 56.35784% +0.00980%
===================================================
Files 88 88
Lines 19124 19126 +2
===================================================
+ Hits 10776 10779 +3
+ Misses 7760 7759 -1
Partials 588 588
Continue to review full report at Codecov.
|
hjpotter92
reviewed
Dec 22, 2022
hjpotter92
reviewed
Dec 22, 2022
thomshutt
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
install_ffmpeg.sh
now installs Tensorflow library and enables it for Ffmpeg withoutexperimental
BUILD_TAGS (no side effects when running in non-Nvidia environment)Dockerfile
copies Tensorflow distribution files to final container, because libtensorflow.so is loaded at runtime by Ffmpeg DNN filter and is not linked statically insidelivepeer
binary, like the rest of dependenciesKudos to @hjpotter92 for helping to figure out Docker stuff.