Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: Set gas tip to 0 on Arb chains #2575

Closed
wants to merge 1 commit into from
Closed

eth: Set gas tip to 0 on Arb chains #2575

wants to merge 1 commit into from

Conversation

yondonfu
Copy link
Member

@yondonfu yondonfu commented Aug 31, 2022

What does this pull request do? Explain your changes. (required)

TODO:

  • Consider refactoring to avoid requesting for a chainID every time SuggestGasTipCap is called (i.e. every time a tx is submitted)?

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #2575 (73aaca8) into master (6bf2087) will decrease coverage by 0.04688%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2575         +/-   ##
===================================================
- Coverage   56.42997%   56.38309%   -0.04688%     
===================================================
  Files             88          88                 
  Lines          18857       18878         +21     
===================================================
+ Hits           10641       10644          +3     
- Misses          7637        7656         +19     
+ Partials         579         578          -1     
Impacted Files Coverage Δ
eth/backend.go 43.82716% <0.00000%> (-6.52746%) ⬇️
discovery/db_discovery.go 69.67509% <0.00000%> (-1.08304%) ⬇️
server/mediaserver.go 67.28972% <0.00000%> (+0.46729%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf2087...73aaca8. Read the comment docs.

Impacted Files Coverage Δ
eth/backend.go 43.82716% <0.00000%> (-6.52746%) ⬇️
discovery/db_discovery.go 69.67509% <0.00000%> (-1.08304%) ⬇️
server/mediaserver.go 67.28972% <0.00000%> (+0.46729%) ⬆️

@yondonfu
Copy link
Member Author

yondonfu commented Sep 7, 2022

SuggestGasTipCap will actually return 0 on Arbitrum so an additional check doesn't seem to be needed.

Also, this PR doesn't actually solve the insufficient funds issue #2574 so closing in favor of #2583

@yondonfu yondonfu closed this Sep 7, 2022
@yondonfu yondonfu deleted the yf/arb-tip-0 branch September 7, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant