Infer capabilities from input codec #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdarkdragon
suggested changes
Feb 2, 2022
darkdarkdragon
suggested changes
Feb 3, 2022
Done. |
|
@cyberj0g could you please rebase it on master? |
560c5b4 to
c278aab
Compare
|
@darkdarkdragon done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is part of #2123 implementation and a follow up to #2150. Will rebase once #2150 is merged.
Specific updates (required)
GetCodecInfoMediaServer.HandlePushto both determine video\audio codec and check if segment doesn't have video framesregisterConnectionto infer additional job capabilities from itHow did you test each of these updates (required)
Tests
Does this pull request close any open issues?
#2123
Checklist:
makeruns successfully./test.shpass