add mp4 download #1879
Merged
add mp4 download #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
618744b to
330cf56
Compare
yondonfu
reviewed
May 18, 2021
yondonfu
requested changes
May 19, 2021
yondonfu
reviewed
May 19, 2021
yondonfu
reviewed
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Adds ability to download recorded stream as .mp4 file
Specific updates (required)
/recordings/endpoint handler changed to recognise .mp4 extension. For media streams (like/recordings/stream-id/240p0.mp4) it will read stored .ts segments one-by-one, transmux them to .mp4 format on the fly and write it as the request output.How did you test each of these updates (required)
Manually
Does this pull request close any open issues?
Fixes #1855
Checklist:
makeruns successfully./test.shpass