Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help descriptions for {min,max}GasPrice #206

Closed
wants to merge 1 commit into from

Conversation

Strykar
Copy link
Contributor

@Strykar Strykar commented Apr 4, 2022

This is no longer in Wei, Arbitrum calls it ArbGas - https://developer.offchainlabs.com/docs/arbgas
Should we be suggesting a min or max gas price in the help on L2?

livepeer_cli will need updating too.

This is no longer in Wei, Arbitrum calls it ArbGas - https://developer.offchainlabs.com/docs/arbgas
Should we be suggesting a min or max gas price in the help on L2?
@vercel
Copy link

vercel bot commented Apr 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/livepeer/docs/DWLjuLdEs55wcggXdoLiEMX2XXrR
✅ Preview: https://docs-git-fork-strykar-patch-7-livepeer.vercel.app

@vercel vercel bot temporarily deployed to Preview April 4, 2022 21:35 Inactive
Copy link
Contributor

@hthillman hthillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, although I'd love a sanity check from @yondonfu

@yondonfu
Copy link
Member

yondonfu commented Apr 7, 2022

The gas price on Arbitrum is still a value denominated in Wei - recall that that the gas fee of a transaction is equal to the "gas price" multiplied by the "gas" used by the transaction.

ArbGas on Arbitrum is analogous to gas on L1 Ethereum so when the term "gas" is used in the context of Arbitrum you can assume that it refers to ArbGas which is just the technical terminology used to distinguish gas on Arbitrum from gas on L1 Ethereum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants