Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1289.json #33

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Conversation

tracedebrake
Copy link

All modes supported, including vertical and horizontal swing (and even both at the same time)

All modes supported, including vertical and horizontal swing (and even both at the same time)
@litinoveweedle
Copy link
Owner

Hello, thank you very much for the contribution. I have just few small requests:

  • Please create only one PR (one PR - it can contains multiple commits to multiple files)
  • Please keep "temperatureUnit": "C", int he file. Those are needed now for handling Fahrenheits as well (Celsius is default, but i added this to all codes as it would raise warning if missing.) I did not yet documented the data files format, so this you couldn't know this, I am going to provide documentation to files ASAP, probably when we will introduce presets.
  • Please give me some time, I would like to write down code quality test for data files, so during the PR merge it will be checked both by format, syntax and logic. I would like to you your PR (as it is first) to test this QC functionality, but I will need few days to write it.

Thank you.

@litinoveweedle
Copy link
Owner

Hello, I implemented detailed checks on the all device data files. Would you be please kind to pull updated master, merge it to your branch and re file the PR? Please also remove Readme update as from now docs are auto generated automatically from the code files. Thank you.

@litinoveweedle litinoveweedle self-assigned this Jul 8, 2024
@litinoveweedle litinoveweedle merged commit d7b0585 into litinoveweedle:master Jul 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants