Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Daikin ATXS20G2V1B, ATXS25G2V1B, ATXS35G2V1B, ATXS42G2V1B, ATXS50G2V1B, FTXS20G2V1B, FTXS25G2V1B, FTXS35G2V1B, FTXS42G2V1B, FTXS50G2V1B and Argo Polifemo #127

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

kenayagi
Copy link

@kenayagi kenayagi commented Sep 5, 2024

No description provided.

…G2V1B, FTXS20G2V1B, FTXS25G2V1B, FTXS35G2V1B, FTXS42G2V1B, FTXS50G2V1B
@litinoveweedle
Copy link
Owner

Thank you for the contribution. Please remove update to the codes documentation - it is auto generated. Thank you.

@litinoveweedle
Copy link
Owner

Unfortunately validation of the code file is failing - you miss temperatureUnit entry. Please test file on your HA installation - there shall be no warning or errors.

@kenayagi
Copy link
Author

kenayagi commented Sep 9, 2024

Hi @litinoveweedle

I couldn't find a place to "check" the configuration on HA (developer tools / yaml / check didn't give any complaints).
I've added temperatureUnit.
Let's see if that passes validation.

@litinoveweedle
Copy link
Owner

Hi @kenayagi, right now the json file checker is run during integration start, when the file is used (referenced in HA yaml smartir configuration). You will find any errors and warnings in he HA logs. There should be no errors and/or warnings/

@litinoveweedle litinoveweedle merged commit ed5a4d8 into litinoveweedle:master Sep 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants