Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid API key errors are incorrectly treated as a success #5

Closed
ryannewington opened this issue Jul 23, 2020 · 4 comments
Closed

Invalid API key errors are incorrectly treated as a success #5

ryannewington opened this issue Jul 23, 2020 · 4 comments
Assignees
@ryannewington
Labels
bug

Comments

@ryannewington
Copy link
Member

Debug build to dump PA request and response XML

Lithnet.Pan.RAProxy.Setup.zip
@ryannewington ryannewington self-assigned this Jul 23, 2020
@ryannewington ryannewington changed the title PA not registering user-id attempts Invalid API key errors are incorrectly treated as a success Jul 24, 2020
@ryannewington
Copy link
Member Author

When API keys contain invalid characters, the error handling logic incorrectly interprets the condition as a success due to a logic bug

@ryannewington
Copy link
Member Author

Updated build with debug logging still turned on

This build will report any API key errors correctly, and also ensures API keys are URL-encoded.

Lithnet.Pan.RAProxy.Setup.zip

@ryannewington
Copy link
Member Author

Lithnet.Pan.RAProxy.Setup.zip

ryannewington added a commit that referenced this issue Jul 27, 2020
@ryannewington
Fixes issue #5
1070f6c
@ryannewington
Copy link
Member Author

Fixed in https://github.com/lithnet/pan-ra-proxy/releases/tag/v1.0.7514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryannewington ryannewington

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryannewington