Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set page title per page #74

Closed
literakl opened this issue Aug 12, 2020 · 3 comments
Closed

Set page title per page #74

literakl opened this issue Aug 12, 2020 · 3 comments
Assignees

Comments

@literakl
Copy link
Owner

There is a fixed page title Mezi námi řidiči for every page. If you open browser history you cannot navigate.

Requirements:

  • The page must have a title equal to item title for polls, or new key in the resource bundle.
  • The title must be preserved in browser history.

Potential implementation:

https://medium.com/@Taha_Shashtari/the-easy-way-to-change-page-title-in-vue-6caf05006863 - via mixin, title set in View file

Router based implementation will not work because we need dynamic titles for polls:

https://dev.to/webhookrelay/a-simple-way-to-keep-your-vue-page-title-in-sync-with-the-router-ec0
vuejs/vue-router#914 (comment) - keeps the history
https://stackoverflow.com/questions/51639850/how-to-change-page-titles-when-using-vue-router

kotte-sanya added a commit that referenced this issue Aug 13, 2020
@literakl
Copy link
Owner Author

page titles must be translated, it cannot be router id

literakl added a commit that referenced this issue Aug 14, 2020
@literakl
Copy link
Owner Author

merged

The dynamic Poll title works only for the first display. When you visit the Poll again, there is only static part in the Chrome tab though the console logs the complete text.

image

GET_POLL fourth-question
Poll.vue:31 Mezi námi řidičiFourth question

kotte-sanya added a commit that referenced this issue Aug 15, 2020
@literakl
Copy link
Owner Author

ok

kotte-sanya added a commit that referenced this issue Aug 15, 2020
literakl added a commit that referenced this issue Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants