Merge pull request mozilla#3351 from lissyx/leak-intermediate-decode

Fix leak in C++ client
lissyx · Sep 29, 2020 · f20f939 · f20f939
2 parents 0c020d1 + 9a34507
commit f20f939
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/native_client/client.cc b/native_client/client.cc
@@ -184,17 +184,22 @@ LocalDsSTT(ModelState* aCtx, const short* aBuffer, size_t aBufferSize,
     }
     size_t off = 0;
     const char *last = nullptr;
+    const char *prev = nullptr;
     while (off < aBufferSize) {
       size_t cur = aBufferSize - off > stream_size ? stream_size : aBufferSize - off;
       DS_FeedAudioContent(ctx, aBuffer + off, cur);
       off += cur;
+      prev = last;
       const char* partial = DS_IntermediateDecode(ctx);
       if (last == nullptr || strcmp(last, partial)) {
         printf("%s\n", partial);
         last = partial;
       } else {
         DS_FreeString((char *) partial);
       }
+      if (prev != nullptr && prev != last) {
+        DS_FreeString((char *) prev);
+      }
     }
     if (last != nullptr) {
       DS_FreeString((char *) last);