Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force context names to lowercase #42

Closed
wants to merge 1 commit into from

Conversation

sgsullivan
Copy link
Contributor

spf13/viper#411

fixes an issue reported by @jvandellen where contexts created with uppercase characters cannot later be modified, because viper converts the user inputted context name to lowercase, causing matching on the key from the config to not match.

~ ❯ lw auth get-contexts                                                                                                           ⏎
Context: HelpfulH2
	Username: helpfulh2
	API URL: https://api.liquidweb.com
	Insecure: false
	Timeout: 90
Context: HelpfulH
	Username: helpfulh
	API URL: https://api.liquidweb.com
	Insecure: false
	Timeout: 90
Current context: [HelpfulH2]
~ ❯ lw auth update-context --context HelpfulH2 --username derp --password derp
A fatal error has occurred:
context with name [HelpfulH2] doesnt exist

spf13/viper#411

fixes an issue where contexts created with uppercase characters cannot
later be modified.
@sgsullivan sgsullivan requested review from jvandellen and dwburke June 19, 2020 16:29
@sgsullivan sgsullivan mentioned this pull request Jun 20, 2020
@sgsullivan sgsullivan closed this Jun 20, 2020
@sgsullivan sgsullivan deleted the force-lowercase-context-names branch June 20, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant