Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use liqo.selectorTemplate for label definitions #2889

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Use liqo.selectorTemplate for label definitions #2889

merged 1 commit into from
Jan 9, 2025

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Jan 2, 2025 •
edited
Loading

Description

This pr fixes the gateway label selectors making it possible to update a running gateway

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Jan 2, 2025
@aleoli
Copy link
Member Author

aleoli commented Jan 2, 2025

/test

@aleoli
Copy link
Member Author

aleoli commented Jan 2, 2025

/test

@aleoli aleoli requested review from cheina97 and fra98 January 2, 2025 12:49
@aleoli aleoli marked this pull request as ready for review January 2, 2025 12:49
@aleoli
Copy link
Member Author

aleoli commented Jan 9, 2025

/test

@aleoli
Copy link
Member Author

aleoli commented Jan 9, 2025

/rebase test=true

@aleoli
Copy link
Member Author

aleoli commented Jan 9, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 9, 2025
@adamjensenbot adamjensenbot merged commit ceca09c into liqotech:master Jan 9, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
fix Fixes a bug in the codebase. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleoli @adamjensenbot @fra98