Merge pull request #6 from lion-packages/bug

Correction of the join method of the Arr class

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2023 Lion-Packages
+Copyright (c) 2022 Lion-Packages
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -16,6 +16,7 @@
 </p>
 
 ## Install
+
 ```bash
 composer require lion/helpers
 ```

src/LionHelpers/Arr.php

@@ -105,6 +105,10 @@ public function join(string $separator = ', ', ?string $lastSeparator = null): s
             return implode($separator, $items);
         }
 
+        if (count($items) <= 1) {
+            return implode($separator, $items);
+        }
+
         $lastElement = array_pop($items);
 
         return implode($separator, $items) . "{$lastSeparator}{$lastElement}";

tests/Providers/ArrProviderTrait.php

@@ -52,6 +52,12 @@ public static function joinProvider(): array
                 'separator' => ', ',
                 'lastSeparator' => null,
                 'return' => 'root'
+            ],
+            [
+                'elements' => self::NAMES,
+                'separator' => ', ',
+                'lastSeparator' => ' and ',
+                'return' => 'root'
             ]
         ];
     }