Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Commit

Permalink
fix: Allow staging users role assumption only by main principal
Browse files Browse the repository at this point in the history
Allowing the S3 Batch Operations service was not necessary after all,
and caused non-prod deployment to hit a known CDK limitation
<aws/aws-cdk#1578>.
  • Loading branch information
l0b0 committed Jun 22, 2021
1 parent c9541c4 commit ed6b6b4
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions infrastructure/constructs/processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,7 @@ def __init__(
staging_users_role = aws_iam.Role(
self,
"staging-users-role",
assumed_by=aws_iam.CompositePrincipal( # type: ignore[arg-type]
principal, aws_iam.ServicePrincipal("batchoperations.s3.amazonaws.com")
),
assumed_by=principal, # type: ignore[arg-type]
max_session_duration=MAX_SESSION_DURATION,
role_name=ResourceName.STAGING_USERS_ROLE_NAME.value,
)
Expand Down

0 comments on commit ed6b6b4

Please sign in to comment.