Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Creating Backup Engine with custom path. #86

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Allow Creating Backup Engine with custom path. #86

merged 1 commit into from
Sep 7, 2022

Conversation

kingster
Copy link
Contributor

@kingster kingster commented Sep 6, 2022

Expose CreateBackupEngine with path param.

Q: Why cant OpenBackupEngine be used instead?
A:

type BackupEngine struct {
	c  *C.rocksdb_backup_engine_t
	db *DB
}

db is private and can't be set externally.

@kingster
Copy link
Contributor Author

kingster commented Sep 6, 2022

Fixed: Compilation Issue.

@kingster kingster mentioned this pull request Sep 6, 2022
Draft
linxGnu
linxGnu approved these changes Sep 7, 2022
View reviewed changes
Copy link
Owner

@linxGnu linxGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thank you

@linxGnu linxGnu merged commit 2aa505c into linxGnu:master Sep 7, 2022
@kingster kingster deleted the patch-1 branch September 7, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linxGnu linxGnu linxGnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingster @linxGnu