-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support a non-hacky way to override link flags #104
Comments
yihuang
changed the title
support a way to override link flags
support a non-hacky way to override link flags
Feb 16, 2023
13 tasks
Sound great to me @yihuang please feel free to make a PR |
@linxGnu there's another thing, there are two APIs are not exported on windows(facebook/rocksdb#11217), currently we use a fork to remove those apis to build for windows, do you want me to submit to upstream for windows support? |
Yes please (although I need to update CI later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have more situations that need to customize the link flags, for example recently I cross compiled the app to mingwW64 with the help of nixpkgs, but there I have to link with
-lrocksdb-shared
.currently there's a way to suppress the builtin link flags, which is the
testing
build tag, it works perfectly right now, it's just the name feels hacky, shall we support sth likegrocksdb_no_link
build tag, where there's no builtin link flags, user can supply withCGO_LDFLAGS
env var?The text was updated successfully, but these errors were encountered: