-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: cross-compiling don't work #874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
Feb 15, 2023
yihuang
commented
Feb 15, 2023
yihuang
commented
Feb 15, 2023
yihuang
commented
Feb 16, 2023
yihuang
force-pushed
the
cross-compiling
branch
4 times, most recently
from
February 22, 2023 03:14
0d052af
to
0c433a5
Compare
yihuang
requested review from
calvinaco and
devashishdxt
and removed request for
a team
February 22, 2023 03:15
Solution: - remove some obstacles, now it at least works for linux. - darwin still need some fixes in nixpkgs side, see: NixOS/nixpkgs#216431 update release flow upload build result to check Problem: windows build in CI fails (crypto-org-chain#868) * Problem: windows build in CI fails Solution: - patch grocksdb to remove binding of not exported apis - add workflow to test windows build in PR * use crypto-org-chain fork update gomod2nix fix mac cross compiling fix cross-compiling tarball windows bundle script support windows tarball add unified job for cross-compiling grocksdb link options configure differnt build machine for different hosts don't fail fast simplify don't run unittest in nix build update grocksdb dependency tidy fix grocksdb grocksdb upstream repo
yihuang
force-pushed
the
cross-compiling
branch
from
February 22, 2023 03:22
0c433a5
to
89746a1
Compare
yihuang
commented
Feb 22, 2023
Signed-off-by: yihuang <huang@crypto.com>
yihuang
force-pushed
the
cross-compiling
branch
from
February 22, 2023 05:51
61b567f
to
04d9bb2
Compare
yihuang
commented
Feb 22, 2023
Signed-off-by: yihuang <huang@crypto.com>
mmsqe
approved these changes
Feb 23, 2023
yihuang
added a commit
to yihuang/cronos
that referenced
this pull request
Feb 23, 2023
Solution: - update nixpkgs and workaround for some issues. Signed-off-by: yihuang <huang@crypto.com>
yihuang
added a commit
that referenced
this pull request
Feb 23, 2023
* Problem: cross-compiling don't work (backport #874) Solution: - update nixpkgs and workaround for some issues. Signed-off-by: yihuang <huang@crypto.com> * remove build-windows job * remove build-windows.sh --------- Signed-off-by: yihuang <huang@crypto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Support cross-compiling modes:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)