-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Qt 6.8 #259
feat: support Qt 6.8 #259
Conversation
support qt 6.8 Log:
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justforlxz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#259
deepin pr auto review代码审查意见:
|
@@ -222,7 +234,12 @@ void DBuiltinIconEngine::paint(QPainter *painter, const QRect &rect, | |||
QIcon(bgFileName).paint(painter, rect, Qt::AlignCenter, mode, state); | |||
} | |||
|
|||
#if QT_VERSION >= QT_VERSION_CHECK(6, 8, 0) | |||
QPixmap pm = entry->pixmap(pixmapSize, mode, state, 1.0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个函数前面有计算 scale
的值,如果Qt这次了,这里应该直接使用 scale,前面的 pixmapSize 就没有必要乘以缩放了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#261 合并了,这个貌似需要处理下
TAG Bot New tag: 5.7.1 |
TAG Bot New tag: 5.7.2 |
TAG Bot New tag: 5.7.3 |
support qt 6.8
Log: