Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 修改包可安装状态获取途径 #89

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

kingjinni
Copy link
Contributor

修改包可安装状态获取途径

Log: 修改包可安装状态获取途径
Change-Id: I806aaee62e04adf6d46bafeed1e5054bf1c66dca

    修改包可安装状态获取途径

Log: 修改包可安装状态获取途径
Change-Id: I806aaee62e04adf6d46bafeed1e5054bf1c66dca
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • shellCmdLocal函数中,使用QProcessEnvironment来设置环境变量可能会导致线程安全问题,因为QProcessEnvironment不是线程安全的。
  • shellCmdLocal函数中的timeout参数没有使用,应该移除或者添加相关逻辑。
  • isPackageInstallable函数中,srcPartssrcList变量被硬编码,这可能不利于代码的维护和配置的灵活性。
  • isPackageInstallable函数中的shellCmdLocal调用没有处理可能出现的错误,例如proc.readAllStandardError()返回的错误信息应该被记录或处理。
  • InstallInterface::startInstallPackages函数中的isPackageInstallable调用没有处理返回的错误,这可能会导致安装流程被阻塞。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kingjinni, winexw

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@winexw winexw merged commit 6d0ec39 into linuxdeepin:master Jul 25, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants