Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加本地数据库查询条件 #85

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

kingjinni
Copy link
Contributor

lastore配置版本高于1.0时才走本地数据库查询

Log: 增加本地数据库查询条件
Task: https://pms.uniontech.com/task-view-357591.html
Change-Id: I28ba40f05f09defc72bb6dfc480b3460dacb3554

    lastore配置版本高于1.0时才走本地数据库查询

Log: 增加本地数据库查询条件
Task: https://pms.uniontech.com/task-view-357591.html
Change-Id: I28ba40f05f09defc72bb6dfc480b3460dacb3554
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • isLastoreConfigVerAccord函数中,config->deleteLater()可能不是必要的,因为DConfig对象在config = DConfig::create(name, name);之后就被使用了。
  • isLastoreConfigVerAccord函数中的qCDebug宏可能不是必要的,因为这是一个静态函数,不会影响程序的性能。
  • stringToVariant函数中没有处理driver为空的情况,可能会导致未定义行为。
  • DriverSearcher::askForFinish函数中的条件判断逻辑可能需要澄清,特别是&& isLastoreConfigVerAccord()这一部分。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kingjinni, winexw

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 25, 2024

TAG Bot

New tag: 1.0.16-1+1060
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #86

@winexw winexw merged commit 9a51632 into linuxdeepin:master Jul 25, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants