use python instead of envpython #181
Conversation
|
[citest bad] |
|
If this change also fixes using python 3.8-dev from Travis, the change to enable it again could be included here as well. |
56d0d76 to
4628a89
Compare
.travis/utils.sh
Outdated
| if [[ -z "$syspython" ]]; then | ||
| syspython=$(command -pv python2) | ||
| fi | ||
| echo ${syspython:-/usr/bin/python3} |
There was a problem hiding this comment.
Sorry, I had to think about this. It seems to be rather odd that /usr/bin/python3 would be a correct choice without it being in PATH. If it is in PATH, it would be set already by line 144. Technically, it should probably fail in this case instead of assuming /usr/bin/python3 to be correct. But maybe this is a wrong assumption. It does not seem to me that this is that important, just wanted to raise it. I am also fine with merging it as-is, since it will probably not hurt. What is your opinion?
There was a problem hiding this comment.
changed to this:
if [[ -z "$syspython" ]]; then
lsr_error Could not determine system python path
fi
echo $syspython
4628a89 to
2f5193c
Compare
Many of the tests and tasks invoked from `tox` would try to use the path to the `python` executable in the tox virtualenv, and in some cases, would try to follow the symlink if the `python` command were a symlink, in some cases, following the symlink to the system python, and trying to use the absolute path. This would fail in some cases because when using the system python with the absolute path, the python modules installed in the tox venv could not be found. So instead, just use the `python` command from the venv with no path. also enable travis 3.8-dev testing, since this fix allows that platform to work correctly.
2f5193c to
4303e47
Compare
Fixed and rebased |
| if [[ -z "$syspython" ]]; then | ||
| syspython=$(command -pv python2) | ||
| fi | ||
| if [[ -z "$syspython" ]]; then |
Many of the tests and tasks invoked from
toxwould try to usethe path to the
pythonexecutable in the tox virtualenv, andin some cases, would try to follow the symlink if the
pythoncommand were a symlink, in some cases, following the symlink to
the system python, and trying to use the absolute path. This
would fail in some cases because when using the system python
with the absolute path, the python modules installed in the
tox venv could not be found. So instead, just use the
pythoncommand from the venv with no path.
also enable travis 3.8-dev testing, since this fix allows that
platform to work correctly.