Onboard refactored tox & Travis CI setup and configuration vol. 9 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i386x
commented
Feb 4, 2020
.travis/runcoveralls.sh
Outdated
| fi | ||
|
|
||
| set -x | ||
| ${ENVPYTHON} ${COVERALLSCMD} ${MAYBE_DEBUG} -v "$@" |
There was a problem hiding this comment.
-v argument actually generates a lot of noise to logs. I propose to remove it if everyone is ok with it.
Give user a possibility to perform some actions before reporting results, particularly - disable publishing coverage reports - specify a mode of the shell script wrapper (strict, debug) - specify a path to tests and tests artifacts
33e9bf9 to
67606e4
Compare
Changes in this PR are already contained in template and therefore there are also in #178 (not counting changes in this PR that are obsolete). I propose to close this when #178 will be merged. |
|
Why not close it now? |
|
you can find test logs for a closed PR, see #122 (click on one of the red crosses). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 9th and last batch of changes introduced by PR #133 (changes are introduced in batches to make reviews easier). List of changes introduced in this PR:
tests/)Note: There are some problems with reporting coverage reports to coveralls.io that are trying to be investigated and solved in PR #120. I propose to continue in investigation of these problems here so publishing coverage reports can be included also to common template.