Onboard refactored tox & Travis CI setup and configuration vol. 8 #151
Conversation
.travis/runtox
Outdated
| lsr_banner "tox" ${BANNERSIZE} | ||
| (set -x; tox); error_code=$? | ||
|
|
||
| if lsr_check_python_version python -le '3.4'; then |
There was a problem hiding this comment.
This now tries to run molecule on Travis for all Python versions but then skips the run because the system libraries can only be accessed for 3.5. This adds a lot of noise to the logs. Technically it should be possible to run all molecule tests except for the molecule_test version with other Python versions (IIRC). Only the molecule_test actually uses the container image. But we probably do not want to do this, running it once is enough, isn't it?
Therefore I propose to also add the check for the python version here to reduce the noise. Or is this not possible because this is before tox?
There was a problem hiding this comment.
Thanks for noting this. Actually, as Travis documentation says, python command here refers also to virtualenv Python, so it should be no problem to implement the check as:
if ! lsr_venv_python_matches_system_python; then
exit $error_code
fic6507fc to
17c8b55
Compare
tox.ini
Outdated
| 3.6: py36,black,custom | ||
| 3.7: py37,custom | ||
| 3.8: py38,custom | ||
| 3.8-dev: py38,custom |
There was a problem hiding this comment.
This does not seem to be needed, py38 already runs when the 3.8-dev version is installed:
https://travis-ci.com/linux-system-roles/network/jobs/281802888#L215
There was a problem hiding this comment.
Ok, I will remove it. Running custom commands only for stable Python versions should be enough.
There was a problem hiding this comment.
Even without the line, the custom command will still run with the python 3.8 development version because 3.8 in this config also matches the development version AFAICS.
There was a problem hiding this comment.
Even without the line, the custom command will still run with the python 3.8 development version.
I do not see the custom command in the log. However, it should be imho enough that the custom command runs in stable Python versions only.
Support running the molecule tests against more versions of Ansible. By typing LSR_ANSIBLE_DEP=<ansible> LSR_MSCENARIO=<scenario> tox -e molecule one can run molecule inside tox with <ansible> version installed under <scenario> scenario. For example LSR_ANSIBLE_DEP='ansible==2.7.*' LSR_MSCENARIO=foo tox -e molecule will run molecule under scenario 'foo' and the recent Ansible 2.7 installed. `tox -e molecule` run molecule under default scenario with the latest Ansible (from pypi) installed. Travis runs molecule tests for Ansible 2.6, 2.7, and 2.8 installed and under default scenario (can be overriden by user in config.sh). Additional changes: Remove useless comment from custom.sh.
17c8b55 to
4b05c20
Compare
|
This PR reflects the changes in linux-system-roles/template@0216bef. |
This is an 8th batch of changes introduced by PR #133 (changes are introduced in batches to make reviews easier). List of changes introduced in this PR: