Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard refactored tox & Travis CI setup and configuration vol. 6 #148

Merged

Conversation

i386x
Copy link
Contributor

@i386x i386x commented Jan 20, 2020

This is a 6th batch of changes introduced by PR #133 (changes are introduced in batches to make reviews easier). List of changes introduced in this PR:

  • remove LSR_MOLECULE_DEPS environment variable (instead, use molecule_extra_requirements.txt permanently as a place where to add additional molecule dependencies)
  • permanently add selinux to molecule dependencies (molecule needs it on selinux enabled systems to setup containers)

Pass extra molecule dependencies via file and not via environment
variable. Also add selinux as a permanent molecule dependency
(molecule needs it on selinux enabled systems to setup containers).
@coveralls
Copy link

Pull Request Test Coverage Report for Build 434

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 433: 0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

Copy link
Member

@tyll tyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@tyll tyll merged commit 09be8c4 into linux-system-roles:master Jan 21, 2020
@i386x
Copy link
Contributor Author

i386x commented Feb 10, 2020

This PR reflects the changes in linux-system-roles/template@b01509f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants