Onboard refactored tox & Travis CI setup and configuration vol. 4 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyll
reviewed
Jan 16, 2020
.travis/custom_pylint.py
Outdated
| @@ -1,7 +1,7 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # SPDX-License-Identifier: MIT | |||
| # | |||
| # Copyright (c) 2019 Red Hat, Inc. | |||
| # Copyright (c) 2019 - 2020 Red Hat, Inc. | |||
There was a problem hiding this comment.
I think it is more common not to use space, i.e. write it as 2019-2020
Prior this change, RUN_PYLINT_* environment variables set by config.sh have effect only while running in Travis (because runtox script sets them by including config.sh). By wrapping pylint runner with shell script, RUN_PYLINT_* environment variables have effect also while running tox locally.
3b1ac00 to
677f7b8
Compare
|
This PR reflects the changes in linux-system-roles/template@c4b3791. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 4th batch of changes introduced by PR #133 (changes are introduced in batches to make reviews easier). List of changes introduced in this PR:
run_pylint.pytocustom_pylint.py(this is what the script really is - a customizedpylint) and move it to.travis/directory where all auxiliary scripts should be placedcustom_pylint.pyvia shell wrapper so environment variables set byconfig.shtakes effect also whentoxruns locally