Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard refactored tox & Travis CI setup and configuration vol. 2 #144

Merged

Conversation

i386x
Copy link
Contributor

@i386x i386x commented Jan 13, 2020

This is a second batch of changes introduced by PR #133 (changes are introduced in batches to make reviews easier). List of changes introduced in this PR:

  • shell wrapper around pytest (decides when to run pytest and with what arguments - some system roles do not contain Python code which confuses pytest)

Not every system role contains parts written in Python, which
confuses pytest. With a shell wrapper around pytest, pytest
can be skipped or run with adjusted parameters depending on the
content or presence of system role's specific directories.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 424

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 421: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

Copy link
Member

@tyll tyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@tyll tyll merged commit 984eb0d into linux-system-roles:master Jan 13, 2020
@i386x
Copy link
Contributor Author

i386x commented Feb 10, 2020

This PR reflects the changes in linux-system-roles/template@b3e503e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants