custom_requirements.txt: Add environment marker #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyll
reviewed
Jan 9, 2020
custom_requirements.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| # SPDX-License-Identifier: MIT | |||
|
|
|||
| # Write requirements for running your custom commands in tox here: | |||
| PyYAML | |||
| PyYAML; python_version >= '2.7' and python_version != '3.0' and python_version != '3.1' and python_version != '3.2' and python_version != '3.3' and python_version != '3.4' | |||
There was a problem hiding this comment.
Does it also support or then this could be python_version == '2.7' or python_version >= '3.5' AFAIU.
There was a problem hiding this comment.
Yes, or operator is also supported. Fixed in 8448660.
Specify on which environments PyYAML should be installed to prevent failing pip install.
8448660 to
668e5fb
Compare
|
Thanks for merging, I will rebase now #142 on top of master. |
You are welcome - not necessary, I rebased it already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify on which environments PyYAML should be installed to prevent
failing pip install.