fix: [M3-7811] - Fix Users & Grants query filtering on user_type #10230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The filter we're applying to child accounts needs to be scoped to child users. Currently, with the parent/child flag on, all users are seeing an error.
From API: "Because this is a computed filter, the API only supports filtering on a single user_type (and no other complex filtering logic), which in this case would be
child
."Changes 🔄
useAccountUsers
that populates the table of non-proxy users to only filter onchild
users when logged into a child or proxy user account. API doesn't support complex filtering logic on this field.numCols
was dynamic for the users in the Business Partner table, and it should not have been. (We don't display the Child Account Access column there, as we do in the other table.)Note
Test coverage for this flow will be completed in M3-7500.
Target release date 🗓️
3/5/2024
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
parent
anddefault
users unless you comment out the proxy user being returned from the */users endpoint. Proxy users will only exist onchild
accounts, so it's never the case that we'd be returning a proxy user for users ofparent
ordefault
type.*/profile
user_type
tochild
. Confirm that both tables load with the expected data (proxy user in the first table, child user(s) in the second).user_type
toproxy
. Confirm the same behavior as above.parent
orchild
with real API data, contact me if you want me to share my parent/child test account details or follow the provisioning instructions to create your own.As an Author I have considered 🤔
Check all that apply