Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test coverage for VPC related methods/functions #673

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

vshanthe
Copy link
Contributor

@vshanthe vshanthe commented Feb 7, 2025

📝 Description

Adding missing unit test coverage for VPC related methods/functions

✔️ How to Test

go test ./test/unit -run TestVPC -v

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@vshanthe vshanthe requested a review from a team as a code owner February 7, 2025 05:11
@vshanthe vshanthe requested review from lgarber-akamai and yec-akamai and removed request for a team February 7, 2025 05:11
@vshanthe vshanthe added the testing for updates to the testing suite in the changelog. label Feb 7, 2025
@vshanthe vshanthe requested a review from ykim-akamai February 7, 2025 05:13
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look really good overall! One thing though, can we use name format like TestName_Method for consistency with rest of the repository? It would help when running set of tests as well

@vshanthe vshanthe requested a review from ykim-akamai February 13, 2025 07:07
@vshanthe vshanthe merged commit 71bdfa1 into linode:main Feb 19, 2025
10 checks passed
@vshanthe vshanthe deleted the vpc_test branch February 19, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants