Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for missing LKE-related endpoints #594

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Added support for missing LKE-related endpoints #594

merged 6 commits into from
Oct 31, 2024

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Added support for the following LKE endpoints:

  • DELETE lke/clusters/$1/kubeconfig
  • GET lke/clusters/$1/nodes/$2
  • POST lke/clusters/$1/nodes/$2/recycle
  • POST lke/clusters/$1/pools/$2/recycle

Also reran some fixtures to sanitize them.

✔️ How to Test

make testint

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner October 25, 2024 15:06
@ezilber-akamai ezilber-akamai requested review from zliang-akamai and ykim-akamai and removed request for a team October 25, 2024 15:06
zliang-akamai
zliang-akamai reviewed Oct 25, 2024
View reviewed changes
zliang-akamai
zliang-akamai approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected, nice job!

@ezilber-akamai ezilber-akamai added the new-feature for new features in the changelog. label Oct 28, 2024
@ezilber-akamai ezilber-akamai added improvement for improvements in existing functionality in the changelog. and removed new-feature for new features in the changelog. labels Oct 28, 2024
ykim-akamai
ykim-akamai approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the unit tests as well!

@ezilber-akamai ezilber-akamai merged commit 551a48a into linode:main Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zliang-akamai zliang-akamai zliang-akamai approved these changes

@ykim-akamai ykim-akamai ykim-akamai approved these changes

Assignees
No one assigned
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezilber-akamai @zliang-akamai @ykim-akamai