Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Refactor smoke tests; improve CI and integration fork workflows #591

Merged
merged 10 commits into from
Oct 31, 2024
Merged

test: Refactor smoke tests; improve CI and integration fork workflows #591

merged 10 commits into from
Oct 31, 2024

Conversation

ykim-akamai
Copy link
Contributor

📝 Description

Smoke test refactor:

  • Added more tests to smoke test suite and changed the LINODE_FIXTURE_MODE to record for smoke tests
  • Implemented Slack notifications

CI:

  • Added condition to exclusively send notification for main repo

Integration-fork:

  • Added job to add CFW to any remaining instances after test execution
  • Separated Calico rules into separate job

✔️ How to Test

make smoketest

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner October 23, 2024 19:10
@ykim-akamai ykim-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team October 23, 2024 19:10
lgarber-akamai
lgarber-akamai approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on my fork, thanks for addressing my feedback!

jriddle-linode
jriddle-linode approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykim-akamai ykim-akamai merged commit e84e404 into linode:main Oct 31, 2024
7 checks passed
@zliang-akamai zliang-akamai added the testing for updates to the testing suite in the changelog. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jriddle-linode jriddle-linode jriddle-linode approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

Assignees
No one assigned
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykim-akamai @jriddle-linode @lgarber-akamai @zliang-akamai