-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropped LongviewSubscription
from AccountSettingsUpdateOptions
#329
Conversation
Why do we need to remove |
According to the ticket description |
I see. Is it possible to mark this field |
Just to add a bit of context, this field can no longer be sent to the API since the API now returns the following error if
It might still be worth keeping the field to prevent introducing a breaking change for downstream consumers, but it might be worth considering to notify users of the non-functional endpoint. Does anyone have any thoughts on this? 🙂 |
Would a deprecation notice in a comment be enough of a notification for users? |
Maybe we can highlight this change in the corresponding release and let the user know the potential breaking change or the API doesn't work this way anymore. I'm also thinking we should let the API doc team know and update the doc as well to reduce confusion. |
I agree that we should probably keep the field to avoid any breaking changes, and I think adding a note to the release is a great idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
📝 Description
Dropped
LongviewSubscription
fromAccountSettingsUpdateOptions
.