Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelector, affinity, and tolerations support to controller StatefulSet #365

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

dominicroessner
Copy link
Contributor

@dominicroessner dominicroessner commented Feb 4, 2025

Resolves #364

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@dominicroessner dominicroessner requested review from a team as code owners February 4, 2025 22:25
@dominicroessner dominicroessner changed the title Add nodeSelector, affinity, and tolerations support to controller Sta… Add nodeSelector, affinity, and tolerations support to controller StatefulSet Feb 4, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.11%. Comparing base (e60af6b) to head (10f0bbd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   73.11%   73.11%           
=======================================
  Files          23       23           
  Lines        2648     2648           
=======================================
  Hits         1936     1936           
  Misses        585      585           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

LGTM. I'll approve and merge it once the CI finishes running

@komer3 komer3 merged commit e1b061c into linode:main Feb 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nodeSelector, affinity, and tolerations support to controller StatefulSet
3 participants