Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ReadWriteOncePod support #326

Merged
merged 2 commits into from
Feb 4, 2025
Merged

feat: ReadWriteOncePod support #326

merged 2 commits into from
Feb 4, 2025

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Nov 25, 2024

https://kubernetes.io/blog/2021/09/13/read-write-once-pod-access-mode-alpha/

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@guilhem guilhem requested review from a team as code owners November 25, 2024 23:48
@guilhem guilhem mentioned this pull request Nov 25, 2024
10 tasks
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.07%. Comparing base (12b1643) to head (6691f57).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   72.98%   73.07%   +0.08%     
==========================================
  Files          23       23              
  Lines        2636     2644       +8     
==========================================
+ Hits         1924     1932       +8     
  Misses        585      585              
  Partials      127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

komer3
komer3 previously approved these changes Dec 2, 2024
@komer3 komer3 merged commit 324eae6 into main Feb 4, 2025
7 checks passed
@komer3 komer3 deleted the ReadWriteOncePod branch February 4, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants