Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Controllerserver (part 2) - createvolume refactor with added test coverage #234

Merged
merged 15 commits into from
Sep 20, 2024

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented Sep 13, 2024

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@komer3 komer3 requested review from a team as code owners September 13, 2024 22:10
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 53.71179% with 106 lines in your changes missing coverage. Please review.

Project coverage is 45.97%. Comparing base (20a6dc1) to head (b2d658a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mocks/mock_linodeclient.go 30.43% 96 Missing ⚠️
internal/driver/controllerserver.go 0.00% 8 Missing ⚠️
internal/driver/controllerserver_helper.go 97.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   40.13%   45.97%   +5.84%     
==========================================
  Files          26       27       +1     
  Lines        1936     2101     +165     
==========================================
+ Hits          777      966     +189     
+ Misses       1120     1090      -30     
- Partials       39       45       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from controllerserver-refactor to main September 19, 2024 19:24
amold1
amold1 previously approved these changes Sep 19, 2024
@komer3 komer3 merged commit 38673fc into main Sep 20, 2024
6 checks passed
@komer3 komer3 deleted the controllerserver-refactor-createvolume branch September 20, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants