Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LKE-3931: Set maxVolumesPerNode to 7 #152

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

rsienko
Copy link
Contributor

@rsienko rsienko commented Jan 11, 2024

This is a quick fix for the default case when we have 8 slots and one slot is already taken by boot disk. There may be more slots in use by non-PVC volumes such as swap but they are not the default in LKE.

fixes #154

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

This is a quick fix for the default case when we have 8 slots and one
slot is already taken by boot disk. There may be more slots in use by
non-PVC volumes such as swap but they are not the default in LKE.

Let's not let perfection be the enemy of good.
@luthermonson
Copy link
Contributor

@kitknox i think you should weigh in on this, there is some logic he suggested we could use to check the disks on the node and make this limit more dynamic. this is probably the quick fix though and we could go with this and ticket the better fix if its too much of a time sink today

@kitknox
Copy link
Contributor

kitknox commented Jan 18, 2024

In the current situation where the API attempts to enforce a limit of 8 block devices, this is an improvement. The downside is that work is planned to improve that to align with the host enforced scalable limit at which point this will be worse. Given workloads are already impacted by the current oversubscription issue there is value in getting this out there but we need to ensure we come back to this quickly when the upstream API shifts.

@rsienko rsienko marked this pull request as ready for review January 26, 2024 12:19
@rsienko rsienko merged commit 3e3d0fd into linode:main Jan 26, 2024
3 checks passed
@rsienko rsienko deleted the bugfix/LKE-3931-max-volumes branch January 26, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linodes currently can only mount 7 volumes PVCs, not 8
5 participants