-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ListVolumes #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c06d64a
to
590151e
Compare
srust
requested changes
Dec 12, 2023
Deal 😀 |
srust
approved these changes
Dec 12, 2023
4a625f8
to
a4c9e06
Compare
luthermonson
approved these changes
Dec 14, 2023
2e57dcd
to
e321939
Compare
If we get an EIO error from statsfs then its safe to assume the PV is not happy
The previous approach defined driver capabilities in two locations and makes the behaviour confusing
We dont want to print the pointer address
The tests validate most of the returned fields of the Volume part of the response but not the VolumeContext and ContentSource fields. All of the fields of the VolumeStatus are validated. The fake LinodeClient has been added in order to easily mock Linode API responses.
e321939
to
e367804
Compare
luthermonson
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
Pull Request Guidelines:
Advertises the capability for Controller ListVolumes which resolves #59 . Allows us to run the
external-health-monitor
and get volume health stats for our PVCs.The PR also consolidates the places where our driver capabilities are set as I spent far too much time wondering why the change in ae2665ea54 wasn't being advertised. Furthermore, this meant that we weren't actually advertising the ability to mount
Testing
Testing this feature requires running the external-health-monitor. I chose to run it as part of the linode controller but we can run it as a separate deployment using leader election.
deploy/kubernetes/base/ss-csi-linode-controller.yaml
with the following extra container and set the csi-driver to my image. Thedeploy/kubernetes/base/ds-csi-linode-node.yaml
should also have it's plugin image update.CSIVolumeHealth
feature gatevolumeHealthStatus
is now being reported.kubectl get --raw "/api/v1/nodes/lke145862-214328-13bc36d60000/proxy/stats/summary"