Update client-go to ~4.0.0 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn, I messed up the build in the last moment. I'll check back tomorrow. |
|
It would be good idea to move away from Kingpin and move to more richer cli interface like https://github.com/spf13/cobra |
|
I'm personally quite happy with kingpin so far. However, I don't mind switching to cobra and would accept PRs for it. What part used in chaoskube do you think is better done with cobra? |
|
@jinankjain Feel free to open an issue for a switch to cobra if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates client-go to the latest version to play nice with recent kubernetes versions.
/cc @jinankjain