Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus metrics #102

Closed
wants to merge 5 commits into from
Closed

Conversation

shaikatz
Copy link

@shaikatz shaikatz commented Aug 28, 2018

Change prometheus package to use latest master (locked by revision as advised in repo) to take advantage of promauto.

Added basic app instrumentation metrics:

  1. Run counter
  2. Error counter
  3. PodsDeleted counter
  4. Pod Deletion timers

That's how it looks:

image

My first PR in Golang, so I'm happy to get some comments and improvements.

I can also implement that with some channels, and it'll be a good start to plugin a slack notifications.

Thoughts?

@shaikatz
Copy link
Author

shaikatz commented Aug 28, 2018

After some rethinking, changed it to channels.

Still has to fix and add tests.

@linki
Copy link
Owner

linki commented Sep 3, 2018

Thanks @shaikatz.

Looks fine from a Go perspective. Can we leave out the channel implementation for now?

@shaikatz shaikatz force-pushed the add-prometheus-metrics branch from 1db0b60 to 7e9655c Compare September 3, 2018 10:32
@shaikatz
Copy link
Author

shaikatz commented Sep 3, 2018

@linki No problem, rebased to the last commit before channels.
I don't see a need for a tests with this approach.
Can we merge that?

@linki
Copy link
Owner

linki commented Sep 17, 2018

@shaikatz I'll have a look this week.

@zbindenren
Copy link
Contributor

@shaikatz a good practice would be to prefix the chaoskube specific metrics with chaoskube_

For example pods_deleted would become chaoskube_pods_deleted etc...

This allows to easily find chaoskube specific counters.

@shaikatz
Copy link
Author

shaikatz commented Nov 8, 2018

Sorry I being in a long vacation, I see that the project advanced a bit in this time, I'll close this PR for now, thanks.

@shaikatz shaikatz closed this Nov 8, 2018
@shaikatz shaikatz deleted the add-prometheus-metrics branch November 8, 2018 11:40
@shaikatz shaikatz restored the add-prometheus-metrics branch November 8, 2018 11:40
linki added a commit that referenced this pull request Jan 8, 2019
Rebase PR #102 and update - prometheus metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants