-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus metrics #102
Conversation
After some rethinking, changed it to channels. Still has to fix and add tests. |
Thanks @shaikatz. Looks fine from a Go perspective. Can we leave out the channel implementation for now? |
1db0b60
to
7e9655c
Compare
@linki No problem, rebased to the last commit before channels. |
@shaikatz I'll have a look this week. |
@shaikatz a good practice would be to prefix the chaoskube specific metrics with For example This allows to easily find chaoskube specific counters. |
Sorry I being in a long vacation, I see that the project advanced a bit in this time, I'll close this PR for now, thanks. |
Rebase PR #102 and update - prometheus metrics
Change prometheus package to use latest master (locked by revision as advised in repo) to take advantage of promauto.
Added basic app instrumentation metrics:
That's how it looks:
My first PR in Golang, so I'm happy to get some comments and improvements.
I can also implement that with some channels, and it'll be a good start to plugin a slack notifications.
Thoughts?