router: Use NewService instead of MakeService #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason for `NewRouter` to operate over `MakeService`. This changes `NewRouter` to build the inner service synchronously, avoiding the need for a `ResponseFuture` that joins `MakeService` and the inner response future.
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Oct 26, 2020
This release adds an 'ingress mode' to support per-request routing for HTTP ingresses. Additionally, the performance impact of logging should be reduced when the proxy log level is not set to `debug` or `trace`. --- * router: Use NewService instead of MakeService (linkerd/linkerd2-proxy#724) * outbound: Split TCP stack into dedicated modules (linkerd/linkerd2-proxy#725) * trace: update `tracing-subscriber` to 0.2.14 (linkerd/linkerd2-proxy#726) * outbound: Extract HTTP and server modules (linkerd/linkerd2-proxy#727) * outbound: Introduce 'ingress mode' (linkerd/linkerd2-proxy#728) * Reduce tracing spans to the debug level (linkerd/linkerd2-proxy#730)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Oct 26, 2020
This release adds an 'ingress mode' to support per-request routing for HTTP ingresses. Additionally, the performance impact of logging should be reduced, especially when the proxy log level is not set to `debug` or `trace`. --- * router: Use NewService instead of MakeService (linkerd/linkerd2-proxy#724) * outbound: Split TCP stack into dedicated modules (linkerd/linkerd2-proxy#725) * trace: update `tracing-subscriber` to 0.2.14 (linkerd/linkerd2-proxy#726) * outbound: Extract HTTP and server modules (linkerd/linkerd2-proxy#727) * outbound: Introduce 'ingress mode' (linkerd/linkerd2-proxy#728) * Reduce tracing spans to the debug level (linkerd/linkerd2-proxy#730)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason for
NewRouterto operate overMakeService. Thischanges
NewRouterto build the inner service synchronously, avoidingthe need for a
ResponseFuturethat joinsMakeServiceand the innerresponse future.