Skip to content

Commit

Permalink
Increase the default buffer capacity to 100K (#752)
Browse files Browse the repository at this point in the history
We've received reports that the default in-flight limit may be too
small. Now that the proxy can consume multiple cores, it seems wise to
increase the default from 10K to 100K.

This bound should prevent high-traffic workloads from hitting the
in-flight limit in all but extreme cases, while still protecting the
proxy against infinite growth.
  • Loading branch information
olix0r authored Nov 23, 2020
1 parent 42a7435 commit b4d9d03
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions linkerd/app/src/env.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ const DEFAULT_RESOLV_CONF: &str = "/etc/resolv.conf";
const DEFAULT_INITIAL_STREAM_WINDOW_SIZE: u32 = 65_535; // Protocol default
const DEFAULT_INITIAL_CONNECTION_WINDOW_SIZE: u32 = 1048576; // 1MB ~ 16 streams at capacity

// 10_000 is arbitrarily chosen for now...
const DEFAULT_BUFFER_CAPACITY: usize = 10_000;
// 100_000 is arbitrarily chosen for now...
const DEFAULT_BUFFER_CAPACITY: usize = 100_000;

// This configuration limits the amount of time Linkerd retains cached clients &
// connections.
Expand Down

0 comments on commit b4d9d03

Please sign in to comment.